dm cache metadata: save in-core policy_hint_size to on-disk superblock
authorMike Snitzer <snitzer@redhat.com>
Thu, 2 Aug 2018 20:08:52 +0000 (16:08 -0400)
committerMike Snitzer <snitzer@redhat.com>
Tue, 7 Aug 2018 18:30:30 +0000 (14:30 -0400)
commitfd2fa95416188a767a63979296fa3e169a9ef5ec
tree18fcd992ce788f48fd53964edaf3fa0d05ebb4c8
parent75294442d896f2767be34f75aca7cc2b0d01301f
dm cache metadata: save in-core policy_hint_size to on-disk superblock

policy_hint_size starts as 0 during __write_initial_superblock().  It
isn't until the policy is loaded that policy_hint_size is set in-core
(cmd->policy_hint_size).  But it never got recorded in the on-disk
superblock because __commit_transaction() didn't deal with transfering
the in-core cmd->policy_hint_size to the on-disk superblock.

The in-core cmd->policy_hint_size gets initialized by metadata_open()'s
__begin_transaction_flags() which re-reads all superblock fields.
Because the superblock's policy_hint_size was never properly stored, when
the cache was created, hints_array_available() would always return false
when re-activating a previously created cache.  This means
__load_mappings() always considered the hints invalid and never made use
of the hints (these hints served to optimize).

Another detremental side-effect of this oversight is the cache_check
utility would fail with: "invalid hint width: 0"

Cc: stable@vger.kernel.org
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-cache-metadata.c