block, bfq: move forward the getting of an extra ref in bfq_bfqq_move
authorPaolo Valente <paolo.valente@linaro.org>
Sat, 21 Mar 2020 09:45:18 +0000 (10:45 +0100)
committerJens Axboe <axboe@kernel.dk>
Sat, 21 Mar 2020 20:30:58 +0000 (14:30 -0600)
commitfd1bb3ae54a9a2e0c42709de861c69aa146b8955
tree865016ef8439e74c8e2e427ce471adc140950968
parent2f95fa5c955d0a9987ffdc3a095e2f4e62c5f2a9
block, bfq: move forward the getting of an extra ref in bfq_bfqq_move

Commit ecedd3d7e199 ("block, bfq: get extra ref to prevent a queue
from being freed during a group move") gets an extra reference to a
bfq_queue before possibly deactivating it (temporarily), in
bfq_bfqq_move(). This prevents the bfq_queue from disappearing before
being reactivated in its new group.

Yet, the bfq_queue may also be expired (i.e., its service may be
stopped) before the bfq_queue is deactivated. And also an expiration
may lead to a premature freeing. This commit fixes this issue by
simply moving forward the getting of the extra reference already
introduced by commit ecedd3d7e199 ("block, bfq: get extra ref to
prevent a queue from being freed during a group move").

Reported-by: cki-project@redhat.com
Tested-by: cki-project@redhat.com
Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bfq-cgroup.c