sched/deadline: Fix reset_on_fork reporting of DL tasks
authorQuentin Perret <qperret@google.com>
Tue, 27 Jul 2021 10:11:01 +0000 (11:11 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Wed, 4 Aug 2021 13:16:43 +0000 (15:16 +0200)
commitf95091536f78971b269ec321b057b8d630b0ad8a
tree01e85f0272872bfddd009272a2e4ae22e9100683
parentf912d051619d11411867f642d2004928eb0b41b1
sched/deadline: Fix reset_on_fork reporting of DL tasks

It is possible for sched_getattr() to incorrectly report the state of
the reset_on_fork flag when called on a deadline task.

Indeed, if the flag was set on a deadline task using sched_setattr()
with flags (SCHED_FLAG_RESET_ON_FORK | SCHED_FLAG_KEEP_PARAMS), then
p->sched_reset_on_fork will be set, but __setscheduler() will bail out
early, which means that the dl_se->flags will not get updated by
__setscheduler_params()->__setparam_dl(). Consequently, if
sched_getattr() is then called on the task, __getparam_dl() will
override kattr.sched_flags with the now out-of-date copy in dl_se->flags
and report the stale value to userspace.

To fix this, make sure to only copy the flags that are relevant to
sched_deadline to and from the dl_se->flags field.

Signed-off-by: Quentin Perret <qperret@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20210727101103.2729607-2-qperret@google.com
kernel/sched/deadline.c
kernel/sched/sched.h