net: x25_asy: Delete the x25_asy driver
authorXie He <xie.he.0141@gmail.com>
Thu, 5 Nov 2020 07:34:34 +0000 (23:34 -0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 7 Nov 2020 22:13:44 +0000 (14:13 -0800)
commitf8ae7bbec726f4d09ca19ecea45ea147b8801e10
treeb7ed1cf9460da0ac7303e32e71058c7d5f515ee6
parent0012eeb370f8c33e8cfb58c1fa7d3e1307940d64
net: x25_asy: Delete the x25_asy driver

This driver transports LAPB (X.25 link layer) frames over TTY links.

I can safely say that this driver has no actual user because it was
not working at all until:
commit 8fdcabeac398 ("drivers/net/wan/x25_asy: Fix to make it work")

The code in its current state still has problems:

1.
The uses of "struct x25_asy" in x25_asy_unesc (when receiving) and in
x25_asy_write_wakeup (when sending) are not protected by locks against
x25_asy_change_mtu's changing of the transmitting/receiving buffers.
Also, all "netif_running" checks in this driver are not protected by
locks against the ndo_stop function.

2.
The driver stops all TTY read/write when the netif is down.
I think this is not right because this may cause the last outgoing frame
before the netif goes down to be incompletely transmitted, and the first
incoming frame after the netif goes up to be incompletely received.

And there may also be other problems.

I was planning to fix these problems but after recent discussions about
deleting other old networking code, I think we may just delete this
driver, too.

Signed-off-by: Xie He <xie.he.0141@gmail.com>
Acked-by: Martin Schiller <ms@dev.tdt.de>
Link: https://lore.kernel.org/r/20201105073434.429307-1-xie.he.0141@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Documentation/process/magic-number.rst
Documentation/translations/it_IT/process/magic-number.rst
Documentation/translations/zh_CN/process/magic-number.rst
arch/mips/configs/gpr_defconfig
arch/mips/configs/mtx1_defconfig
drivers/net/wan/Kconfig
drivers/net/wan/Makefile
drivers/net/wan/x25_asy.c [deleted file]
drivers/net/wan/x25_asy.h [deleted file]