libnvdimm: Out of bounds read in __nd_ioctl()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 25 Feb 2020 16:20:56 +0000 (19:20 +0300)
committerDan Williams <dan.j.williams@intel.com>
Sat, 29 Feb 2020 02:21:52 +0000 (18:21 -0800)
commitf84afbdd3a9e5e10633695677b95422572f920dc
tree6a29d775d3d3623ae8068ba8105f2f96cb2fe520
parent01091c496f920e634ea84b689f480c39016752a8
libnvdimm: Out of bounds read in __nd_ioctl()

The "cmd" comes from the user and it can be up to 255.  It it's more
than the number of bits in long, it results out of bounds read when we
check test_bit(cmd, &cmd_mask).  The highest valid value for "cmd" is
ND_CMD_CALL (10) so I added a compare against that.

Fixes: 62232e45f4a2 ("libnvdimm: control (ioctl) messages for nvdimm_bus and nvdimm devices")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200225162055.amtosfy7m35aivxg@kili.mountain
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/nvdimm/bus.c