mac80211: drop check for DONT_REORDER in __ieee80211_select_queue
authorFelix Fietkau <nbd@nbd.name>
Wed, 10 Nov 2021 21:22:01 +0000 (22:22 +0100)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 15 Nov 2021 09:55:40 +0000 (10:55 +0100)
commitf6ab25d41b18f3d26883cb9c20875e1a85c4f05b
tree092e6f2c3b82e840b84adb0211957c1df12edce5
parentc033a38a81bc539d6c0db8c5387e0b14d819a0cf
mac80211: drop check for DONT_REORDER in __ieee80211_select_queue

When __ieee80211_select_queue is called, skb->cb has not been cleared yet,
which means that info->control.flags can contain garbage.
In some cases this leads to IEEE80211_TX_CTRL_DONT_REORDER being set, causing
packets marked for other queues to randomly end up in BE instead.

This flag only needs to be checked in ieee80211_select_queue_80211, since
the radiotap parser is the only piece of code that sets it

Fixes: 66d06c84730c ("mac80211: adhere to Tx control flag that prevents frame reordering")
Cc: stable@vger.kernel.org
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Link: https://lore.kernel.org/r/20211110212201.35452-1-nbd@nbd.name
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/wme.c