perf beauty: Reuse the generic arch errno switch
authorIan Rogers <irogers@google.com>
Thu, 13 May 2021 06:04:41 +0000 (23:04 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 2 Aug 2021 12:56:18 +0000 (09:56 -0300)
commitf463ad7f41d3a042653f55959c77e28db56cb312
tree818c9c133e222418f3e90a84ec7609725fb22f17
parentc44fc5af3cdcd7e414b793903054e4e9b0999306
perf beauty: Reuse the generic arch errno switch

Previously the code would see if, for example,
tools/perf/arch/arm/include/uapi/asm/errno.h exists and if not generate
a "generic" switch statement using the asm-generic/errno.h.

This creates multiple identical "generic" switch statements before the
default generic switch statement for an unknown architecture.

By simplifying the archlist to be only for architectures that are not
"generic" the amount of generated code can be reduced from 14 down to 6
functions.

Remove the special case of x86, instead reverse the architecture names
so that it comes first.

Committer testing:

  $ tools/perf/trace/beauty/arch_errno_names.sh gcc tools > before

Apply this patch and:

  $ tools/perf/trace/beauty/arch_errno_names.sh gcc tools > after

14 arches down to 6, that are the ones with an explicit errno.h file:

  $ ls -1 tools/arch/*/include/uapi/asm/errno.h
  tools/arch/alpha/include/uapi/asm/errno.h
  tools/arch/mips/include/uapi/asm/errno.h
  tools/arch/parisc/include/uapi/asm/errno.h
  tools/arch/powerpc/include/uapi/asm/errno.h
  tools/arch/sparc/include/uapi/asm/errno.h
  tools/arch/x86/include/uapi/asm/errno.h
  $

  $ diff -u4 before after
  @@ -2099,32 +987,16 @@
   const char *arch_syscalls__strerrno(const char *arch, int err)
   {
    if (!strcmp(arch, "x86"))
    return errno_to_name__x86(err);
  - if (!strcmp(arch, "alpha"))
  - return errno_to_name__alpha(err);
  - if (!strcmp(arch, "arc"))
  - return errno_to_name__arc(err);
  - if (!strcmp(arch, "arm"))
  - return errno_to_name__arm(err);
  - if (!strcmp(arch, "arm64"))
  - return errno_to_name__arm64(err);
  - if (!strcmp(arch, "csky"))
  - return errno_to_name__csky(err);
  - if (!strcmp(arch, "mips"))
  - return errno_to_name__mips(err);
  - if (!strcmp(arch, "parisc"))
  - return errno_to_name__parisc(err);
  - if (!strcmp(arch, "powerpc"))
  - return errno_to_name__powerpc(err);
  - if (!strcmp(arch, "riscv"))
  - return errno_to_name__riscv(err);
  - if (!strcmp(arch, "s390"))
  - return errno_to_name__s390(err);
  - if (!strcmp(arch, "sh"))
  - return errno_to_name__sh(err);
    if (!strcmp(arch, "sparc"))
    return errno_to_name__sparc(err);
  - if (!strcmp(arch, "xtensa"))
  - return errno_to_name__xtensa(err);
  + if (!strcmp(arch, "powerpc"))
  + return errno_to_name__powerpc(err);
  + if (!strcmp(arch, "parisc"))
  + return errno_to_name__parisc(err);
  + if (!strcmp(arch, "mips"))
  + return errno_to_name__mips(err);
  + if (!strcmp(arch, "alpha"))
  + return errno_to_name__alpha(err);
    return errno_to_name__generic(err);
   }

The rest of the patch is the removal of the errno_to_name__generic()
unneeded clones.

Signed-off-by: Ian Rogers <irogers@google.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20210513060441.408507-1-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/trace/beauty/arch_errno_names.sh