kgdb: Honour the kprobe blocklist when setting breakpoints
authorDaniel Thompson <daniel.thompson@linaro.org>
Sun, 27 Sep 2020 21:15:29 +0000 (22:15 +0100)
committerDaniel Thompson <daniel.thompson@linaro.org>
Mon, 28 Sep 2020 11:14:08 +0000 (12:14 +0100)
commitf2d10ff4a903813df767a4b56b651a26b938df06
treea6969351434aa9c2eac82e8bec42115a01df2507
parente16c33e290792c9b71b952dc915e5f7dfc9d4409
kgdb: Honour the kprobe blocklist when setting breakpoints

Currently kgdb has absolutely no safety rails in place to discourage or
prevent a user from placing a breakpoint in dangerous places such as
the debugger's own trap entry/exit and other places where it is not safe
to take synchronous traps.

Introduce a new config symbol KGDB_HONOUR_BLOCKLIST and modify the
default implementation of kgdb_validate_break_address() so that we use
the kprobe blocklist to prohibit instrumentation of critical functions
if the config symbol is set. The config symbol dependencies are set to
ensure that the blocklist will be enabled by default if we enable KGDB
and are compiling for an architecture where we HAVE_KPROBES.

Suggested-by: Peter Zijlstra <peterz@infradead.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Link: https://lore.kernel.org/r/20200927211531.1380577-2-daniel.thompson@linaro.org
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
include/linux/kgdb.h
kernel/debug/debug_core.c
kernel/debug/kdb/kdb_bp.c
lib/Kconfig.kgdb