ASoC: es8316: Fix possible NULL pointer deref in es8316_disable_jack_detect()
authorHans de Goede <hdegoede@redhat.com>
Tue, 12 Jan 2021 10:17:25 +0000 (11:17 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 12 Jan 2021 14:12:02 +0000 (14:12 +0000)
commitf2973a1de9d9890b6ac712fb1825d3449ee9cc93
tree87d6f5e3ba833ad99914f1514f941406f31b1ebf
parent554a1b00957ec1033994a2d03b5b8eac59a24f3c
ASoC: es8316: Fix possible NULL pointer deref in es8316_disable_jack_detect()

sound/soc/soc-core.c: soc_remove_component() unconditionally calls
snd_soc_component_set_jack(component, NULL, NULL); on any components
being removed.

This means that on machines where the machine-driver does not provide
a jack through snd_soc_component_set_jack() es8316_disable_jack_detect()
will still get called and at this time es8316->jack will be NULL and
the es8316->jack->status check in es8316_disable_jack_detect() will
lead to a NULL pointer deref.

Fix this by checking for es8316->jack bein NULL at the start of
es8316_disable_jack_detect() and turn the function into a no-op in
that case.

Cc: russianneuromancer <russianneuromancer@ya.ru>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210112101725.44200-1-hdegoede@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/es8316.c