dm: use bio_split() when splitting out the already processed bio
authorMike Snitzer <snitzer@redhat.com>
Fri, 15 Jun 2018 13:35:33 +0000 (09:35 -0400)
committerMike Snitzer <snitzer@redhat.com>
Fri, 22 Jun 2018 18:51:11 +0000 (14:51 -0400)
commitf21c601a2bb319ec19eb4562eadc7797d90fd90e
treedf0ce3160517405987f0c657422861e200d50f9e
parentce397d215ccd07b8ae3f71db689aedb85d56ab40
dm: use bio_split() when splitting out the already processed bio

Use of bio_clone_bioset() is inefficient if there is no need to clone
the original bio's bio_vec array.  Best to use the bio_clone_fast()
variant.  Also, just using bio_advance() is only part of what is needed
to properly setup the clone -- it doesn't account for the various
bio_integrity() related work that also needs to be performed (see
bio_split).

Address both of these issues by switching from bio_clone_bioset() to
bio_split().

Fixes: 18a25da8 ("dm: ensure bio submission follows a depth-first tree walk")
Cc: stable@vger.kernel.org # 4.15+, requires removal of '&' before md->queue->bio_split
Reported-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: NeilBrown <neilb@suse.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm.c