io_uring: don't forget to task-cancel drained reqs
authorPavel Begunkov <asml.silence@gmail.com>
Thu, 5 Nov 2020 14:06:19 +0000 (14:06 +0000)
committerJens Axboe <axboe@kernel.dk>
Thu, 5 Nov 2020 16:15:24 +0000 (09:15 -0700)
commitef9865a442286e2737f37f56eb54c12ef8465905
tree453e5741e011199802f722057090d626b0807741
parent99b328084f6a98bcee9fcd423c82ccfd52115da5
io_uring: don't forget to task-cancel drained reqs

If there is a long-standing request of one task locking up execution of
deferred requests, and the defer list contains requests of another task
(all files-less), then a potential execution of __io_uring_task_cancel()
by that another task will sleep until that first long-standing request
completion, and that may take long.

E.g.
tsk1: req1/read(empty_pipe) -> tsk2: req(DRAIN)
Then __io_uring_task_cancel(tsk2) waits for req1 completion.

It seems we even can manufacture a complicated case with many tasks
sharing many rings that can lock them forever.

Cancel deferred requests for __io_uring_task_cancel() as well.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c