ice: Fix potential infinite loop when using u8 loop counter
authorColin Ian King <colin.king@canonical.com>
Wed, 31 Mar 2021 14:46:28 +0000 (15:46 +0100)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 13 Apr 2021 18:50:38 +0000 (11:50 -0700)
commitef963ae427aa4669905e0a96b3bd9d44dc85db32
tree14c8e914aa1bc07994b71531b938e1ba6fceb3f0
parentdebb9df311582c83fe369baa35fa4b92e8a9c58a
ice: Fix potential infinite loop when using u8 loop counter

A for-loop is using a u8 loop counter that is being compared to
a u32 cmp_dcbcfg->numapp to check for the end of the loop. If
cmp_dcbcfg->numapp is larger than 255 then the counter j will wrap
around to zero and hence an infinite loop occurs. Fix this by making
counter j the same type as cmp_dcbcfg->numapp.

Addresses-Coverity: ("Infinite loop")
Fixes: aeac8ce864d9 ("ice: Recognize 860 as iSCSI port in CEE mode")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_dcb.c