PCI: Unify ECAM constants in native PCI Express drivers
authorKrzysztof Wilczyński <kw@linux.com>
Sun, 29 Nov 2020 23:07:39 +0000 (23:07 +0000)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 10 Dec 2020 20:55:49 +0000 (14:55 -0600)
commite7708f5b10e205d6291bb495e645a03553b9768b
treed5e75ab43df73998f3b8b5481fad766dc087a793
parentf8394f232b1eab649ce2df5c5f15b0e528c92091
PCI: Unify ECAM constants in native PCI Express drivers

Add ECAM-related constants to provide a set of standard constants
defining memory address shift values to the byte-level address that can
be used to access the PCI Express Configuration Space, and then move
native PCI Express controller drivers to use the newly introduced
definitions retiring driver-specific ones.

Refactor pci_ecam_map_bus() function to use newly added constants so
that limits to the bus, device function and offset (now limited to 4K as
per the specification) are in place to prevent the defective or
malicious caller from supplying incorrect configuration offset and thus
targeting the wrong device when accessing extended configuration space.

This refactor also allows for the ".bus_shift" initialisers to be
dropped when the user is not using a custom value as a default value
will be used as per the PCI Express Specification.

Thanks to Qian Cai <qcai@redhat.com>, Michael Walle <michael@walle.cc>,
and Vladimir Oltean <olteanv@gmail.com> for reporting a pci_ecam_create()
issue with .bus_shift and to Vladimir for proposing the fix.

[bhelgaas: incorporate Vladimir's fix, update commit log]
Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://lore.kernel.org/r/20201129230743.3006978-2-kw@linux.com
Tested-by: Michael Walle <michael@walle.cc>
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Jon Derrick <jonathan.derrick@intel.com>
Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
14 files changed:
drivers/pci/controller/dwc/pcie-al.c
drivers/pci/controller/dwc/pcie-hisi.c
drivers/pci/controller/pci-aardvark.c
drivers/pci/controller/pci-host-generic.c
drivers/pci/controller/pci-thunder-ecam.c
drivers/pci/controller/pcie-brcmstb.c
drivers/pci/controller/pcie-rockchip-host.c
drivers/pci/controller/pcie-rockchip.h
drivers/pci/controller/pcie-tango.c
drivers/pci/controller/pcie-xilinx-nwl.c
drivers/pci/controller/pcie-xilinx.c
drivers/pci/controller/vmd.c
drivers/pci/ecam.c
include/linux/pci-ecam.h