dm rq: don't call blk_mq_queue_stopped() in dm_stop_queue()
authorMing Lei <ming.lei@redhat.com>
Fri, 19 Jun 2020 08:42:14 +0000 (16:42 +0800)
committerMike Snitzer <snitzer@redhat.com>
Mon, 20 Jul 2020 15:17:42 +0000 (11:17 -0400)
commite766668c6cd49d741cfb49eaeb38998ba34d27bc
tree32cbb6b928ae61335409d593db19655696bcaab6
parent0c248ea27fc88cf8a3035ba0ed75b210be9abf80
dm rq: don't call blk_mq_queue_stopped() in dm_stop_queue()

dm_stop_queue() only uses blk_mq_quiesce_queue() so it doesn't
formally stop the blk-mq queue; therefore there is no point making the
blk_mq_queue_stopped() check -- it will never be stopped.

In addition, even though dm_stop_queue() actually tries to quiesce hw
queues via blk_mq_quiesce_queue(), checking with blk_queue_quiesced()
to avoid unnecessary queue quiesce isn't reliable because: the
QUEUE_FLAG_QUIESCED flag is set before synchronize_rcu() and
dm_stop_queue() may be called when synchronize_rcu() from another
blk_mq_quiesce_queue() is in-progress.

Fixes: 7b17c2f7292ba ("dm: Fix a race condition related to stopping and starting queues")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-rq.c