acl: handle idmapped mounts
authorChristian Brauner <christian.brauner@ubuntu.com>
Thu, 21 Jan 2021 13:19:27 +0000 (14:19 +0100)
committerChristian Brauner <christian.brauner@ubuntu.com>
Sun, 24 Jan 2021 13:27:17 +0000 (14:27 +0100)
commite65ce2a50cf6af216bea6fd80d771fcbb4c0aaa1
treeb137cac7f442a182e02f1cd9d66acd643f61bcff
parent2f221d6f7b881d95de1f356a3097d755ab1e47d4
acl: handle idmapped mounts

The posix acl permission checking helpers determine whether a caller is
privileged over an inode according to the acls associated with the
inode. Add helpers that make it possible to handle acls on idmapped
mounts.

The vfs and the filesystems targeted by this first iteration make use of
posix_acl_fix_xattr_from_user() and posix_acl_fix_xattr_to_user() to
translate basic posix access and default permissions such as the
ACL_USER and ACL_GROUP type according to the initial user namespace (or
the superblock's user namespace) to and from the caller's current user
namespace. Adapt these two helpers to handle idmapped mounts whereby we
either map from or into the mount's user namespace depending on in which
direction we're translating.
Similarly, cap_convert_nscap() is used by the vfs to translate user
namespace and non-user namespace aware filesystem capabilities from the
superblock's user namespace to the caller's user namespace. Enable it to
handle idmapped mounts by accounting for the mount's user namespace.

In addition the fileystems targeted in the first iteration of this patch
series make use of the posix_acl_chmod() and, posix_acl_update_mode()
helpers. Both helpers perform permission checks on the target inode. Let
them handle idmapped mounts. These two helpers are called when posix
acls are set by the respective filesystems to handle this case we extend
the ->set() method to take an additional user namespace argument to pass
the mount's user namespace down.

Link: https://lore.kernel.org/r/20210121131959.646623-9-christian.brauner@ubuntu.com
Cc: Christoph Hellwig <hch@lst.de>
Cc: David Howells <dhowells@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
72 files changed:
Documentation/filesystems/locking.rst
Documentation/filesystems/porting.rst
fs/9p/acl.c
fs/9p/xattr.c
fs/afs/xattr.c
fs/btrfs/acl.c
fs/btrfs/inode.c
fs/btrfs/xattr.c
fs/ceph/acl.c
fs/ceph/inode.c
fs/ceph/xattr.c
fs/cifs/xattr.c
fs/ecryptfs/inode.c
fs/ext2/acl.c
fs/ext2/inode.c
fs/ext2/xattr_security.c
fs/ext2/xattr_trusted.c
fs/ext2/xattr_user.c
fs/ext4/acl.c
fs/ext4/inode.c
fs/ext4/xattr_hurd.c
fs/ext4/xattr_security.c
fs/ext4/xattr_trusted.c
fs/ext4/xattr_user.c
fs/f2fs/acl.c
fs/f2fs/file.c
fs/f2fs/xattr.c
fs/fuse/xattr.c
fs/gfs2/acl.c
fs/gfs2/inode.c
fs/gfs2/xattr.c
fs/hfs/attr.c
fs/hfsplus/xattr.c
fs/hfsplus/xattr_security.c
fs/hfsplus/xattr_trusted.c
fs/hfsplus/xattr_user.c
fs/jffs2/acl.c
fs/jffs2/fs.c
fs/jffs2/security.c
fs/jffs2/xattr_trusted.c
fs/jffs2/xattr_user.c
fs/jfs/acl.c
fs/jfs/file.c
fs/jfs/xattr.c
fs/kernfs/inode.c
fs/nfs/nfs4proc.c
fs/nfsd/nfs2acl.c
fs/nfsd/nfs3acl.c
fs/nfsd/nfs4acl.c
fs/ocfs2/acl.c
fs/ocfs2/xattr.c
fs/orangefs/acl.c
fs/orangefs/inode.c
fs/orangefs/xattr.c
fs/overlayfs/super.c
fs/posix_acl.c
fs/reiserfs/xattr_acl.c
fs/reiserfs/xattr_security.c
fs/reiserfs/xattr_trusted.c
fs/reiserfs/xattr_user.c
fs/ubifs/xattr.c
fs/xattr.c
fs/xfs/xfs_acl.c
fs/xfs/xfs_iops.c
fs/xfs/xfs_xattr.c
include/linux/capability.h
include/linux/posix_acl.h
include/linux/posix_acl_xattr.h
include/linux/xattr.h
mm/shmem.c
net/socket.c
security/commoncap.c