timer: Read jiffies once when forwarding base clk
authorLi RongQing <lirongqing@baidu.com>
Thu, 19 Sep 2019 12:04:47 +0000 (20:04 +0800)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 19 Sep 2019 15:50:11 +0000 (17:50 +0200)
commite430d802d6a3aaf61bd3ed03d9404888a29b9bf9
tree3a3c74bcfeaa98291f1f3f47a771d7113512b6af
parent7f2444d38f6bbfa12bc15e2533d8f9daa85ca02b
timer: Read jiffies once when forwarding base clk

The timer delayed for more than 3 seconds warning was triggered during
testing.

  Workqueue: events_unbound sched_tick_remote
  RIP: 0010:sched_tick_remote+0xee/0x100
  ...
  Call Trace:
   process_one_work+0x18c/0x3a0
   worker_thread+0x30/0x380
   kthread+0x113/0x130
   ret_from_fork+0x22/0x40

The reason is that the code in collect_expired_timers() uses jiffies
unprotected:

    if (next_event > jiffies)
        base->clk = jiffies;

As the compiler is allowed to reload the value base->clk can advance
between the check and the store and in the worst case advance farther than
next event. That causes the timer expiry to be delayed until the wheel
pointer wraps around.

Convert the code to use READ_ONCE()

Fixes: 236968383cf5 ("timers: Optimize collect_expired_timers() for NOHZ")
Signed-off-by: Li RongQing <lirongqing@baidu.com>
Signed-off-by: Liang ZhiCheng <liangzhicheng@baidu.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/1568894687-14499-1-git-send-email-lirongqing@baidu.com
kernel/time/timer.c