fuse: fix use after free in fuse_read_interrupt()
authorMiklos Szeredi <mszeredi@redhat.com>
Wed, 4 Aug 2021 11:22:58 +0000 (13:22 +0200)
committerMiklos Szeredi <mszeredi@redhat.com>
Wed, 4 Aug 2021 11:22:58 +0000 (13:22 +0200)
commite1e71c168813564be0f6ea3d6740a059ca42d177
treefae8cc56016feb9703453a553229b4161d62e49f
parente73f0f0ee7541171d89f2e2491130c7771ba58d3
fuse: fix use after free in fuse_read_interrupt()

There is a potential race between fuse_read_interrupt() and
fuse_request_end().

TASK1
  in fuse_read_interrupt(): delete req->intr_entry (while holding
  fiq->lock)

TASK2
  in fuse_request_end(): req->intr_entry is empty -> skip fiq->lock
  wake up TASK3

TASK3
  request is freed

TASK1
  in fuse_read_interrupt(): dereference req->in.h.unique ***BAM***

Fix by always grabbing fiq->lock if the request was ever interrupted
(FR_INTERRUPTED set) thereby serializing with concurrent
fuse_read_interrupt() calls.

FR_INTERRUPTED is set before the request is queued on fiq->interrupts.
Dequeing the request is done with list_del_init() but FR_INTERRUPTED is not
cleared in this case.

Reported-by: lijiazi <lijiazi@xiaomi.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/fuse/dev.c