net-sysfs: Call dev_hold always in netdev_queue_add_kobject
authorJouni Hogander <jouni.hogander@unikie.com>
Thu, 5 Dec 2019 13:57:07 +0000 (15:57 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 7 Dec 2019 04:37:28 +0000 (20:37 -0800)
commite0b60903b434a7ee21ba8d8659f207ed84101e89
treedb257ebecc51e1d5276c19c782162947d7c643a8
parent8bef0af09a5415df761b04fa487a6c34acae74bc
net-sysfs: Call dev_hold always in netdev_queue_add_kobject

Dev_hold has to be called always in netdev_queue_add_kobject.
Otherwise usage count drops below 0 in case of failure in
kobject_init_and_add.

Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject")
Reported-by: Hulk Robot <hulkci@huawei.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: David Miller <davem@davemloft.net>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/net-sysfs.c