Fix use after free in get_tree_bdev()
authorDavid Howells <dhowells@redhat.com>
Tue, 28 Apr 2020 20:27:48 +0000 (21:27 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 28 Apr 2020 21:37:40 +0000 (14:37 -0700)
commitdd7bc8158b413e0b580c491e8bd18cb91057c7c2
treec50f4a1e9fc7769c7f5c6b7bf0d4b1ab7085bf18
parentedb98d162418e90d6d2c1cec42e09be0375cfd88
Fix use after free in get_tree_bdev()

Commit 6fcf0c72e4b9, a fix to get_tree_bdev() put a missing blkdev_put() in
the wrong place, before a warnf() that displays the bdev under
consideration rather after it.

This results in a silent lockup in printk("%pg") called via warnf() from
get_tree_bdev() under some circumstances when there's a race with the
blockdev being frozen.  This can be caused by xfstests/tests/generic/085 in
combination with Lukas Czerner's ext4 mount API conversion patchset.  It
looks like it ought to occur with other users of get_tree_bdev() such as
XFS, but apparently doesn't.

Fix this by switching the order of the lines.

Fixes: 6fcf0c72e4b9 ("vfs: add missing blkdev_put() in get_tree_bdev()")
Reported-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Ian Kent <raven@themaw.net>
cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/super.c