arm64: mte: Lock a page for MTE tag initialisation
authorCatalin Marinas <catalin.marinas@arm.com>
Fri, 4 Nov 2022 01:10:38 +0000 (18:10 -0700)
committerMarc Zyngier <maz@kernel.org>
Tue, 29 Nov 2022 09:26:07 +0000 (09:26 +0000)
commitd77e59a8fccde7fb5dd8c57594ed147b4291c970
tree91f819cd2db98a86c098c0302d213c2035f2f3cb
parentef6458b1b6ca3fdb991ce4182e981a88d4c58c0f
arm64: mte: Lock a page for MTE tag initialisation

Initialising the tags and setting PG_mte_tagged flag for a page can race
between multiple set_pte_at() on shared pages or setting the stage 2 pte
via user_mem_abort(). Introduce a new PG_mte_lock flag as PG_arch_3 and
set it before attempting page initialisation. Given that PG_mte_tagged
is never cleared for a page, consider setting this flag to mean page
unlocked and wait on this bit with acquire semantics if the page is
locked:

- try_page_mte_tagging() - lock the page for tagging, return true if it
  can be tagged, false if already tagged. No acquire semantics if it
  returns true (PG_mte_tagged not set) as there is no serialisation with
  a previous set_page_mte_tagged().

- set_page_mte_tagged() - set PG_mte_tagged with release semantics.

The two-bit locking is based on Peter Collingbourne's idea.

Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Peter Collingbourne <pcc@google.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Peter Collingbourne <pcc@google.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20221104011041.290951-6-pcc@google.com
arch/arm64/include/asm/mte.h
arch/arm64/include/asm/pgtable.h
arch/arm64/kernel/cpufeature.c
arch/arm64/kernel/mte.c
arch/arm64/kvm/guest.c
arch/arm64/kvm/mmu.c
arch/arm64/mm/copypage.c
arch/arm64/mm/fault.c
arch/arm64/mm/mteswap.c