drm/amd/display: Fix reset sequence with driver direct DMCUB fw load
authorNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Mon, 14 Dec 2020 15:50:33 +0000 (10:50 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 20 Jan 2021 21:38:19 +0000 (16:38 -0500)
commitd740a39c3dde99f9d8afc5aff8e56bdb48d8be9b
tree06b9f3b0acad61ee3cff55ef581d8a12ef94281c
parent44a09e3d95bd2b7b0c224100f78f335859c4e193
drm/amd/display: Fix reset sequence with driver direct DMCUB fw load

[Why]
DMCUB encounters a page fault/double exception with driver direct load
because DMCUB is not held in soft reset after releasing secure reset.

The clean shutdown sequence via GPINT is also not executed in this
sequence which leaves hardware behavior in an indeterminate state.

[How]
Move reset earlier in the sequence.

Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Reviewed-by: Eric Yang <eric.yang2@amd.com>
Acked-by: Anson Jacob <anson.jacob@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c