video: fbdev: vga16fb: fix setting of pixclock because a pass-by-value error
authorColin Ian King <colin.king@canonical.com>
Thu, 23 Jul 2020 17:02:27 +0000 (18:02 +0100)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Tue, 8 Sep 2020 11:33:03 +0000 (13:33 +0200)
commitc72fab81ceaa54408b827a2f0486d9a0f4be34cf
tree933dfb217b7de3e3ca53feda947a6ec1ffc751d4
parentbcee1609ba9623f35597f06a2ad118ac4ade2974
video: fbdev: vga16fb: fix setting of pixclock because a pass-by-value error

The pixclock is being set locally because it is being passed as a
pass-by-value argument rather than pass-by-reference, so the computed
pixclock is never being set in var->pixclock. Fix this by passing
by reference.

[This dates back to 2002, I found the offending commit from the git
history git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git ]

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Jani Nikula <jani.nikula@intel.com>
[b.zolnierkie: minor patch summary fixup]
[b.zolnierkie: removed "Fixes:" tag (not in upstream tree)]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200723170227.996229-1-colin.king@canonical.com
drivers/video/fbdev/vga16fb.c