net: phylink: fix ethtool -A with attached PHYs
authorRussell King <rmk+kernel@armlinux.org.uk>
Tue, 23 Jun 2020 16:47:23 +0000 (17:47 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 24 Jun 2020 03:53:28 +0000 (20:53 -0700)
commitc718af2d00a37587b09e5958d142da7569f3d55b
tree947e5cfd1b0fec2114b4ce39859a99d07aa3b9fa
parent41b14fb8724d5a4b382a63cb4a1a61880347ccb8
net: phylink: fix ethtool -A with attached PHYs

Fix a phylink's ethtool set_pauseparam support deadlock caused by phylib
interacting with phylink: we must not hold the state lock while calling
phylib functions that may call into phylink_phy_change().

Fixes: f904f15ea9b5 ("net: phylink: allow ethtool -A to change flow control advertisement")
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phylink.c