net: usb: asix: ax88772: Fix less than zero comparison of a u16
authorColin Ian King <colin.king@canonical.com>
Wed, 9 Jun 2021 10:24:48 +0000 (11:24 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 9 Jun 2021 21:54:03 +0000 (14:54 -0700)
commitc6be5a22fde5f5cbcef3e1473efbeb312aed1f0e
tree4adf49c3c1c5d401176841c8ce91c45db567ef34
parente67665946599abe0ae8d454ceb6bad4b1d1d6189
net: usb: asix: ax88772: Fix less than zero comparison of a u16

The comparison of the u16 priv->phy_addr < 0 is always false because
phy_addr is unsigned. Fix this by assigning the return from the call
to function asix_read_phy_addr to int ret and using this for the
less than zero error check comparison.

Fixes: 7e88b11a862a ("net: usb: asix: refactor asix_read_phy_addr() and handle errors on return")
Addresses-Coverity: ("Unsigned compared against 0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/ax88172a.c