block: call blk_mq_exit_queue from disk_release for never added disks
authorChristoph Hellwig <hch@lst.de>
Wed, 20 Jul 2022 13:05:41 +0000 (15:05 +0200)
committerJens Axboe <axboe@kernel.dk>
Thu, 21 Jul 2022 16:59:02 +0000 (10:59 -0600)
commitc5db2cfc6274692d821d33b59acb6ff615e350c1
tree1f9c99668b9be71dd61a60e02228e60ec1351e24
parent0a3e5cc7bbfcd571a2e53779ef7d7aa3c57d5432
block: call blk_mq_exit_queue from disk_release for never added disks

To undo the all initialization from blk_mq_init_allocated_queue in case
of a probe failure where add_disk is never called we have to call
blk_mq_exit_queue from put_disk.

This relies on the fact that drivers always call blk_mq_free_tag_set
after calling put_disk in the probe error path if they have a gendisk
at all.

We should be doing this in general, but can't do it for the normal
teardown case (yet) as the tagset can be gone by the time the disk is
released once it was added.  I hope to sort this out properly eventually
but for now this isolated hack will do it.

Fixes: 6f8191fdf41d ("block: simplify disk shutdown")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20220720130541.1323531-2-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/genhd.c