configfs: fix a race in configfs_lookup()
authorSishuai Gong <sishuai@purdue.edu>
Wed, 25 Aug 2021 05:52:20 +0000 (07:52 +0200)
committerChristoph Hellwig <hch@lst.de>
Wed, 25 Aug 2021 05:58:49 +0000 (07:58 +0200)
commitc42dd069be8dfc9b2239a5c89e73bbd08ab35de0
treee537efef13add0360bd77adb2818a56a318eea42
parentd07f132a225c013e59aa77f514ad9211ecab82ee
configfs: fix a race in configfs_lookup()

When configfs_lookup() is executing list_for_each_entry(),
it is possible that configfs_dir_lseek() is calling list_del().
Some unfortunate interleavings of them can cause a kernel NULL
pointer dereference error

Thread 1                  Thread 2
//configfs_dir_lseek()    //configfs_lookup()
list_del(&cursor->s_sibling);
                         list_for_each_entry(sd, ...)

Fix this by grabbing configfs_dirent_lock in configfs_lookup()
while iterating ->s_children.

Signed-off-by: Sishuai Gong <sishuai@purdue.edu>
Signed-off-by: Christoph Hellwig <hch@lst.de>
fs/configfs/dir.c