net: cdc_eem: fix tx fixup skb leak
authorLinyu Yuan <linyyuan@codeaurora.org>
Wed, 16 Jun 2021 23:32:32 +0000 (07:32 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 Jun 2021 18:30:25 +0000 (11:30 -0700)
commitc3b26fdf1b32f91c7a3bc743384b4a298ab53ad7
treecf74e5adb2a3d2e3ef625b3b8b7c4be188789128
parentbc39f6792ede3a830b1893c9133636b9f6991e59
net: cdc_eem: fix tx fixup skb leak

when usbnet transmit a skb, eem fixup it in eem_tx_fixup(),
if skb_copy_expand() failed, it return NULL,
usbnet_start_xmit() will have no chance to free original skb.

fix it by free orginal skb in eem_tx_fixup() first,
then check skb clone status, if failed, return NULL to usbnet.

Fixes: 9f722c0978b0 ("usbnet: CDC EEM support (v5)")
Signed-off-by: Linyu Yuan <linyyuan@codeaurora.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/cdc_eem.c