drm/vc4: crtc: Make sure the HDMI controller is powered when disabling
authorMaxime Ripard <maxime@cerno.tech>
Thu, 23 Sep 2021 18:50:13 +0000 (20:50 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Mon, 25 Oct 2021 13:33:41 +0000 (15:33 +0200)
commitbca10db67bdaf15997a5a2a276e7aa9b6eea1393
treecb57bd1f931b62374db740cf096e54c19661da49
parent14e193b95604182a338e3721385e3d8a56d3c5a8
drm/vc4: crtc: Make sure the HDMI controller is powered when disabling

Since commit 875a4d536842 ("drm/vc4: drv: Disable the CRTC at boot
time"), during the initial setup of the driver we call into the VC4 HDMI
controller hooks to make sure the controller is properly disabled.

However, we were never making sure that the device was properly powered
while doing so. This never resulted in any (reported) issue in practice,
but since the introduction of commit 4209f03fcb8e ("drm/vc4: hdmi: Warn
if we access the controller while disabled") we get a loud complaint
when we do that kind of access.

Let's make sure we have the HDMI controller properly powered while
disabling it.

Fixes: 875a4d536842 ("drm/vc4: drv: Disable the CRTC at boot time")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: Nicolas Saenz Julienne <nsaenz@kernel.org>
Tested-by: Nicolas Saenz Julienne <nsaenz@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210923185013.826679-1-maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_crtc.c