watchdog: qcom-wdt: Convert to use device managed functions and other improvements
authorGuenter Roeck <linux@roeck-us.net>
Tue, 9 Apr 2019 17:23:50 +0000 (10:23 -0700)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 5 May 2019 19:02:26 +0000 (21:02 +0200)
commitbba07e6ed72e98b7ee5a9c6d5a90ff786080d1f4
treec93b3d606c3cf42be932bd5ab222774c76f74f15
parent9723a82a97df45c1e80730d554db4f45f0394c50
watchdog: qcom-wdt: Convert to use device managed functions and other improvements

Use device managed functions to simplify error handling, reduce
source code size, improve readability, and reduce the likelyhood of bugs.
Other improvements as listed below.

The conversion was done automatically with coccinelle using the
following semantic patches. The semantic patches and the scripts
used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches

- Drop assignments to otherwise unused variables
- Drop empty remove function
- Use devm_add_action_or_reset() for calls to clk_disable_unprepare
- Introduce local variable 'struct device *dev' and use it instead of
  dereferencing it repeatedly
- Use devm_watchdog_register_driver() to register watchdog device

Cc: Andy Gross <andy.gross@linaro.org>
Cc: David Brown <david.brown@linaro.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/qcom-wdt.c