icmp: randomize the global rate limiter
authorEric Dumazet <edumazet@google.com>
Thu, 15 Oct 2020 18:42:00 +0000 (11:42 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 16 Oct 2020 23:47:09 +0000 (16:47 -0700)
commitb38e7819cae946e2edf869e604af1e65a5d241c5
tree3950efd4431d1dfa82b181415329aac165e48d50
parent137d23cea1c044b2d4853ac71bc68126b25fdbb2
icmp: randomize the global rate limiter

Keyu Man reported that the ICMP rate limiter could be used
by attackers to get useful signal. Details will be provided
in an upcoming academic publication.

Our solution is to add some noise, so that the attackers
no longer can get help from the predictable token bucket limiter.

Fixes: 4cdf507d5452 ("icmp: add a global rate limitation")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Keyu Man <kman001@ucr.edu>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Documentation/networking/ip-sysctl.rst
net/ipv4/icmp.c