xsk: Fix for xp_aligned_validate_desc() when len == chunk_size
authorXuan Zhuo <xuanzhuo@linux.alibaba.com>
Wed, 28 Apr 2021 09:44:24 +0000 (17:44 +0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Mon, 3 May 2021 22:28:06 +0000 (00:28 +0200)
commitac31565c21937eee9117e43c9cd34f557f6f1cb8
tree8359163fe639b92bb0dfcedc3530450c765ed386
parent2a30f9440640c418bcfbea9b2b344d268b58e0a2
xsk: Fix for xp_aligned_validate_desc() when len == chunk_size

When desc->len is equal to chunk_size, it is legal. But when the
xp_aligned_validate_desc() got chunk_end from desc->addr + desc->len
pointing to the next chunk during the check, it caused the check to
fail.

This problem was first introduced in bbff2f321a86 ("xsk: new descriptor
addressing scheme"). Later in 2b43470add8c ("xsk: Introduce AF_XDP buffer
allocation API") this piece of code was moved into the new function called
xp_aligned_validate_desc(). This function was then moved into xsk_queue.h
via 26062b185eee ("xsk: Explicitly inline functions and move definitions").

Fixes: bbff2f321a86 ("xsk: new descriptor addressing scheme")
Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
Link: https://lore.kernel.org/bpf/20210428094424.54435-1-xuanzhuo@linux.alibaba.com
net/xdp/xsk_queue.h