iommu/vt-d: Fix PASID leak in intel_svm_unbind_mm()
authorFenghua Yu <fenghua.yu@intel.com>
Sat, 28 Aug 2021 07:06:21 +0000 (15:06 +0800)
committerJoerg Roedel <jroedel@suse.de>
Thu, 9 Sep 2021 11:18:06 +0000 (13:18 +0200)
commita21518cb23a3c7d49bafcb59862fd389fd829d4b
treeb99e66045ca6ea37c562744731404ac39a7ce704
parenteb03f2d2f6a4da25d286613717d10add9ce9f175
iommu/vt-d: Fix PASID leak in intel_svm_unbind_mm()

The mm->pasid will be used in intel_svm_free_pasid() after load_pasid()
during unbinding mm. Clearing it in load_pasid() will cause PASID cannot
be freed in intel_svm_free_pasid().

Additionally mm->pasid was updated already before load_pasid() during pasid
allocation. No need to update it again in load_pasid() during binding mm.
Don't update mm->pasid to avoid the issues in both binding mm and unbinding
mm.

Fixes: 4048377414162 ("iommu/vt-d: Use iommu_sva_alloc(free)_pasid() helpers")
Reported-and-tested-by: Dave Jiang <dave.jiang@intel.com>
Co-developed-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Link: https://lore.kernel.org/r/20210826215918.4073446-1-fenghua.yu@intel.com
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Link: https://lore.kernel.org/r/20210828070622.2437559-2-baolu.lu@linux.intel.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/intel/svm.c