io_uring: fix lack of protection for compl_nr
authorHao Xu <haoxu@linux.alibaba.com>
Fri, 20 Aug 2021 22:19:54 +0000 (06:19 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 23 Aug 2021 19:10:46 +0000 (13:10 -0600)
commit99c8bc52d1321ab3a711eba2941eadbe7425230f
tree0bbbe1f3d0adb68888e119468af7801425e136e3
parent187f08c12cd1d81f000cdc9c0119ef6e0a6f47e3
io_uring: fix lack of protection for compl_nr

coml_nr in ctx_flush_and_put() is not protected by uring_lock, this
may cause problems when accessing in parallel:

say coml_nr > 0

  ctx_flush_and put                  other context
   if (compl_nr)                      get mutex
                                      coml_nr > 0
                                      do flush
                                          coml_nr = 0
                                      release mutex
        get mutex
           do flush (*)
        release mutex

in (*) place, we call io_cqring_ev_posted() and users likely get
no events there. To avoid spurious events, re-check the value when
under the lock.

Fixes: 2c32395d8111 ("io_uring: fix __tctx_task_work() ctx race")
Signed-off-by: Hao Xu <haoxu@linux.alibaba.com>
Link: https://lore.kernel.org/r/20210820221954.61815-1-haoxu@linux.alibaba.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c