device property: Don't clear secondary pointer for shared primary firmware node
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 22 Oct 2020 18:41:00 +0000 (21:41 +0300)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 27 Oct 2020 18:20:03 +0000 (19:20 +0100)
commit99aed9227073fb34ce2880cbc7063e04185a65e1
tree1ad09224ff8e8fcb88575b70c593bebc230556d1
parentd5dcce0c414fcbfe4c2037b66ac69ea5f9b3f75c
device property: Don't clear secondary pointer for shared primary firmware node

It appears that firmware nodes can be shared between devices. In such case
when a (child) device is about to be deleted, its firmware node may be shared
and ACPI_COMPANION_SET(..., NULL) call for it breaks the secondary link
of the shared primary firmware node.

In order to prevent that, check, if the device has a parent and parent's
firmware node is shared with its child, and avoid crashing the link.

Fixes: c15e1bdda436 ("device property: Fix the secondary firmware node handling in set_primary_fwnode()")
Reported-by: Ferry Toth <fntoth@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Tested-by: Ferry Toth <fntoth@gmail.com>
Cc: 5.9+ <stable@vger.kernel.org> # 5.9+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/base/core.c