Merge branch 'do-not-use-rt_tos-for-ipv6-flowlabel'
authorJakub Kicinski <kuba@kernel.org>
Wed, 10 Aug 2022 05:19:23 +0000 (22:19 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 10 Aug 2022 05:19:24 +0000 (22:19 -0700)
commit996237d9ba4d092469fbfca18995656c32834ac7
tree0ce31b098bb79f7f08e82de92de6d6ca25c1e3f4
parentb4ab94d6adaa5cf842b68bd28f4b50bc774496bd
parentab7e2e0dfa5d37540ab1dc5376e9a2cb9188925d
Merge branch 'do-not-use-rt_tos-for-ipv6-flowlabel'

Matthias May says:

====================
Do not use RT_TOS for IPv6 flowlabel

According to Guillaume Nault RT_TOS should never be used for IPv6.

Quote:
RT_TOS() is an old macro used to interprete IPv4 TOS as described in
the obsolete RFC 1349. It's conceptually wrong to use it even in IPv4
code, although, given the current state of the code, most of the
existing calls have no consequence.

But using RT_TOS() in IPv6 code is always a bug: IPv6 never had a "TOS"
field to be interpreted the RFC 1349 way. There's no historical
compatibility to worry about.
====================

Link: https://lore.kernel.org/r/20220805191906.9323-1-matthias.may@westermo.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>