net: vxge: fix use-after-free in vxge_device_unregister
authorPavel Skripkin <paskripkin@gmail.com>
Wed, 4 Aug 2021 15:52:20 +0000 (18:52 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 5 Aug 2021 14:29:50 +0000 (07:29 -0700)
commit942e560a3d3862dd5dee1411dbdd7097d29b8416
tree0d91afa203ba3073ca16db355728b62ba3d7d30a
parent44712965bf12ae1758cec4de53816ed4b914ca1a
net: vxge: fix use-after-free in vxge_device_unregister

Smatch says:
drivers/net/ethernet/neterion/vxge/vxge-main.c:3518 vxge_device_unregister() error: Using vdev after free_{netdev,candev}(dev);
drivers/net/ethernet/neterion/vxge/vxge-main.c:3518 vxge_device_unregister() error: Using vdev after free_{netdev,candev}(dev);
drivers/net/ethernet/neterion/vxge/vxge-main.c:3520 vxge_device_unregister() error: Using vdev after free_{netdev,candev}(dev);
drivers/net/ethernet/neterion/vxge/vxge-main.c:3520 vxge_device_unregister() error: Using vdev after free_{netdev,candev}(dev);

Since vdev pointer is netdev private data accessing it after free_netdev()
call can cause use-after-free bug. Fix it by moving free_netdev() call at
the end of the function

Fixes: 6cca200362b4 ("vxge: cleanup probe error paths")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/neterion/vxge/vxge-main.c