libnvdimm: Validate command family indices
authorDan Williams <dan.j.williams@intel.com>
Mon, 20 Jul 2020 22:07:30 +0000 (15:07 -0700)
committerVishal Verma <vishal.l.verma@intel.com>
Sun, 26 Jul 2020 01:34:47 +0000 (19:34 -0600)
commit92fe2aa859f52ce6aa595ca97fec110dc7100e63
treea4e9961101ae85bcd8eef82f383f3fc3707b8ebd
parent48778464bb7d346b47157d21ffde2af6b2d39110
libnvdimm: Validate command family indices

The ND_CMD_CALL format allows for a general passthrough of passlisted
commands targeting a given command set. However there is no validation
of the family index relative to what the bus supports.

- Update the NFIT bus implementation (the only one that supports
  ND_CMD_CALL passthrough) to also passlist the valid set of command
  family indices.

- Update the generic __nd_ioctl() path to validate that field on behalf
  of all implementations.

Fixes: 31eca76ba2fc ("nfit, libnvdimm: limited/whitelisted dimm command marshaling mechanism")
Cc: Vishal Verma <vishal.l.verma@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Ira Weiny <ira.weiny@intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
drivers/acpi/nfit/core.c
drivers/acpi/nfit/nfit.h
drivers/nvdimm/bus.c
include/linux/libnvdimm.h
include/uapi/linux/ndctl.h