firmware: tee_bnxt: Release TEE shm, session, and context during kexec
authorAllen Pais <apais@linux.microsoft.com>
Mon, 14 Jun 2021 22:33:17 +0000 (17:33 -0500)
committerJens Wiklander <jens.wiklander@linaro.org>
Wed, 21 Jul 2021 05:55:50 +0000 (07:55 +0200)
commit914ab19e471d8fb535ed50dff108b0a615f3c2d8
treea4b20326b4440c751c1ab28dc9ce46f342a194f9
parentdfb703ad2a8d366b829818a558337be779746575
firmware: tee_bnxt: Release TEE shm, session, and context during kexec

Implement a .shutdown hook that will be called during a kexec operation
so that the TEE shared memory, session, and context that were set up
during .probe can be properly freed/closed.

Additionally, don't use dma-buf backed shared memory for the
fw_shm_pool. dma-buf backed shared memory cannot be reliably freed and
unregistered during a kexec operation even when tee_shm_free() is called
on the shm from a .shutdown hook. The problem occurs because
dma_buf_put() calls fput() which then uses task_work_add(), with the
TWA_RESUME parameter, to queue tee_shm_release() to be called before the
current task returns to user mode. However, the current task never
returns to user mode before the kexec completes so the memory is never
freed nor unregistered.

Use tee_shm_alloc_kernel_buf() to avoid dma-buf backed shared memory
allocation so that tee_shm_free() can directly call tee_shm_release().
This will ensure that the shm can be freed and unregistered during a
kexec operation.

Fixes: 246880958ac9 ("firmware: broadcom: add OP-TEE based BNXT f/w manager")
Cc: stable@vger.kernel.org
Signed-off-by: Allen Pais <apais@linux.microsoft.com>
Co-developed-by: Tyler Hicks <tyhicks@linux.microsoft.com>
Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com>
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
drivers/firmware/broadcom/tee_bnxt_fw.c