perf hists: Fix determination of a callchain node's childlessness
authorAndres Freund <andres@anarazel.de>
Wed, 30 Mar 2016 19:02:45 +0000 (21:02 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 30 Mar 2016 21:08:39 +0000 (18:08 -0300)
commit909890355507e92bdaf648e73870f6b5df606da8
tree890ec9b1b6f9f9ad29adb46c39136230984fc3e2
parentf6343be96ebbae38a07e0878810f5bbc0c38cade
perf hists: Fix determination of a callchain node's childlessness

The 4b3a3212233a ("perf hists browser: Support flat callchains") commit
over-aggressively tried to optimize callchain_node__init_have_children().

That lead to --tui mode not allowing to expand call chain elements if a
call chain element had only one parent. That's why --inverted callgraphs
looked halfway sane, but plain ones didn't.

Revert that individual optimization, it wasn't really related to the
rest of the commit.

Signed-off-by: Andres Freund <andres@anarazel.de>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Fixes: 4b3a3212233a ("perf hists browser: Support flat callchains")
Link: http://lkml.kernel.org/r/20160330190245.GB13305@awork2.anarazel.de
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/browsers/hists.c