ftrace: Handle commands when closing set_ftrace_filter file
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Wed, 5 May 2021 14:38:24 +0000 (10:38 -0400)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Wed, 5 May 2021 14:38:24 +0000 (10:38 -0400)
commit8c9af478c06bb1ab1422f90d8ecbc53defd44bc3
tree2761954a67d2b651e317c83fd2594b17c3e89693
parentaafe104aa9096827a429bc1358f8260ee565b7cc
ftrace: Handle commands when closing set_ftrace_filter file

 # echo switch_mm:traceoff > /sys/kernel/tracing/set_ftrace_filter

will cause switch_mm to stop tracing by the traceoff command.

 # echo -n switch_mm:traceoff > /sys/kernel/tracing/set_ftrace_filter

does nothing.

The reason is that the parsing in the write function only processes
commands if it finished parsing (there is white space written after the
command). That's to handle:

 write(fd, "switch_mm:", 10);
 write(fd, "traceoff", 8);

cases, where the command is broken over multiple writes.

The problem is if the file descriptor is closed, then the write call is
not processed, and the command needs to be processed in the release code.
The release code can handle matching of functions, but does not handle
commands.

Cc: stable@vger.kernel.org
Fixes: eda1e32855656 ("tracing: handle broken names in ftrace filter")
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/ftrace.c