drm/i915: fix size_t greater or equal to zero comparison
authorColin Ian King <colin.king@canonical.com>
Fri, 2 Oct 2020 17:03:54 +0000 (18:03 +0100)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Tue, 8 Dec 2020 15:03:43 +0000 (07:03 -0800)
commit88c52d805eb61da99aa4607fb5131f41c0ff6bd4
treedd64eca7de52b901114a0b9572adf345665b09b9
parent0fe8bf4d3edce7aad6c14b9d5d92ff54dc19f0ba
drm/i915: fix size_t greater or equal to zero comparison

Currently the check that the unsigned size_t variable i is >= 0
is always true because the unsigned variable will never be negative,
causing the loop to run forever.  Fix this by changing the
pre-decrement check to a zero check on i followed by a decrement of i.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: bfed6708d6c9 ("drm/i915: use vmap in shmem_pin_map")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20201002170354.94627-1-colin.king@canonical.com
(cherry picked from commit e70956a2498dc81d8f2522cba074f55ae910e13c)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/gt/shmem_utils.c