io_uring: Ensure mask is initialized in io_arm_poll_handler
authorNathan Chancellor <natechancellor@gmail.com>
Mon, 2 Mar 2020 23:01:19 +0000 (16:01 -0700)
committerJens Axboe <axboe@kernel.dk>
Mon, 2 Mar 2020 23:13:24 +0000 (16:13 -0700)
commit8755d97a09fed0de206772bcad1838301293c4d8
tree722013595ae51eead3dab4102d16e38305e7aa92
parent3b17cf5a58f2a38e23ee980b5dece717d0464fb7
io_uring: Ensure mask is initialized in io_arm_poll_handler

Clang warns:

fs/io_uring.c:4178:6: warning: variable 'mask' is used uninitialized
whenever 'if' condition is false [-Wsometimes-uninitialized]
        if (def->pollin)
            ^~~~~~~~~~~
fs/io_uring.c:4182:2: note: uninitialized use occurs here
        mask |= POLLERR | POLLPRI;
        ^~~~
fs/io_uring.c:4178:2: note: remove the 'if' if its condition is always
true
        if (def->pollin)
        ^~~~~~~~~~~~~~~~
fs/io_uring.c:4154:15: note: initialize the variable 'mask' to silence
this warning
        __poll_t mask, ret;
                     ^
                      = 0
1 warning generated.

io_op_defs has many definitions where pollin is not set so mask indeed
might be uninitialized. Initialize it to zero and change the next
assignment to |=, in case further masks are added in the future to avoid
missing changing the assignment then.

Fixes: d7718a9d25a6 ("io_uring: use poll driven retry for files that support it")
Link: https://github.com/ClangBuiltLinux/linux/issues/916
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c