parisc: Drop parisc special case for __sighandler_t
authorHelge Deller <deller@gmx.de>
Fri, 13 Nov 2020 02:53:31 +0000 (18:53 -0800)
committerEric W. Biederman <ebiederm@xmission.com>
Mon, 23 Nov 2020 16:31:04 +0000 (10:31 -0600)
commit8663daeac7a1fd1b200e3365ccc9403f026f2fc8
treeec6763f0663d51b0d9f7ca8a20d432cb5154fb22
parentf8394f232b1eab649ce2df5c5f15b0e528c92091
parisc: Drop parisc special case for __sighandler_t

I believe we can and *should* drop this parisc-specific typedef for
__sighandler_t when compiling a 64-bit kernel. The reasons:

1. We don't have a 64-bit userspace yet, so nothing (on userspace side)
can break.

2. Inside the Linux kernel, this is only used in kernel/signal.c, in
function kernel_sigaction() where the signal handler is compared against
SIG_IGN.  SIG_IGN is defined as (__sighandler_t)1), so only the pointers
are compared.

3. Even when a 64-bit userspace gets added at some point, I think
__sighandler_t should be defined what it is: a function pointer struct.

I compiled kernel/signal.c with and without the patch, and the produced code
is identical in both cases.

Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Peter Collingbourne <pcc@google.com>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Reviewed-by: Peter Collingbourne <pcc@google.com>
Link: https://linux-review.googlesource.com/id/I21c43f21b264f339e3aa395626af838646f62d97
Link: https://lkml.kernel.org/r/a75b8eb7bb9eac1cf73fb119eb53e5892d6e9656.1605235762.git.pcc@google.com
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
arch/parisc/include/uapi/asm/signal.h