RDMA/qib: Validate ->show()/store() callbacks before calling them
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 7 Nov 2019 03:20:25 +0000 (08:50 +0530)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 14 Nov 2019 15:49:15 +0000 (11:49 -0400)
commit7ee23491b39259ae83899dd93b2a29ef0f22f0a7
tree924f3d8b13496eddaf6e1a2417d8b2a4964b0bac
parentda046d5f895fca18d63b15ac8faebd5bf784e23a
RDMA/qib: Validate ->show()/store() callbacks before calling them

The permissions of the read-only or write-only sysfs files can be
changed (as root) and the user can then try to read a write-only file or
write to a read-only file which will lead to kernel crash here.

Protect against that by always validating the show/store callbacks.

Link: https://lore.kernel.org/r/d45cc26361a174ae12dbb86c994ef334d257924b.1573096807.git.viresh.kumar@linaro.org
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/qib/qib_sysfs.c