iommu/arm-smmu: Fix arm_smmu_device refcount leak in address translation
authorXiyu Yang <xiyuyang19@fudan.edu.cn>
Thu, 10 Jun 2021 02:49:20 +0000 (10:49 +0800)
committerWill Deacon <will@kernel.org>
Fri, 11 Jun 2021 10:39:17 +0000 (11:39 +0100)
commit7c8f176d6a3fa18aa0f8875da6f7c672ed2a8554
tree1bfddf7e072df4bb07d581c135d9c7e26009255b
parent1adf30f198c26539a62d761e45af72cde570413d
iommu/arm-smmu: Fix arm_smmu_device refcount leak in address translation

The reference counting issue happens in several exception handling paths
of arm_smmu_iova_to_phys_hard(). When those error scenarios occur, the
function forgets to decrease the refcount of "smmu" increased by
arm_smmu_rpm_get(), causing a refcount leak.

Fix this issue by jumping to "out" label when those error scenarios
occur.

Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Reviewed-by: Rob Clark <robdclark@chromium.org>
Link: https://lore.kernel.org/r/1623293391-17261-1-git-send-email-xiyuyang19@fudan.edu.cn
Signed-off-by: Will Deacon <will@kernel.org>
drivers/iommu/arm/arm-smmu/arm-smmu.c