ovl: fix missing revert_creds() on error path
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 23 Mar 2021 13:19:35 +0000 (16:19 +0300)
committerMiklos Szeredi <mszeredi@redhat.com>
Mon, 12 Apr 2021 10:00:36 +0000 (12:00 +0200)
commit7b279bbfd2b230c7a210ff8f405799c7e46bbf48
treeb63c4c5a7a870cf49cd993e199b52df21090a30c
parenteaab1d45cdb4bb0c846bd23c3d666d5b90af7b41
ovl: fix missing revert_creds() on error path

Smatch complains about missing that the ovl_override_creds() doesn't
have a matching revert_creds() if the dentry is disconnected.  Fix this
by moving the ovl_override_creds() until after the disconnected check.

Fixes: aa3ff3c152ff ("ovl: copy up of disconnected dentries")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/overlayfs/copy_up.c