misc: xilinx-sdfec: Drop unnecessary NULL check after container_of
authorGuenter Roeck <linux@roeck-us.net>
Fri, 21 May 2021 20:04:57 +0000 (13:04 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 May 2021 20:14:48 +0000 (22:14 +0200)
commit78429edfeed8da0562243e876be46d700f9ed13c
tree531d728bab3f456c8bd55e08052e77400bd84e1e
parentb63866efa10ca5e4497f17eb3e3a03dc6929c49e
misc: xilinx-sdfec: Drop unnecessary NULL check after container_of

container_of() only returns NULL if the passed pointer is NULL _and_ if
the embedded element is the first element of the structure. Even if that
is the case, testing against it is misleading and possibly dangerous
because the position of the embedded element may change. In this case,
the check is unnecessary since it is known that file->private_data is
never NULL for an open file, and container_of() will therefore also
never be NULL. Drop the check.

Acked-by: Dragan Cvetic <dragan.cvetic@xilinx.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20210521200457.2112041-1-linux@roeck-us.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/xilinx_sdfec.c