perf scripting perl: Add common_callchain to fix argument order
authorMichael Petlan <mpetlan@redhat.com>
Wed, 11 Mar 2020 13:28:36 +0000 (14:28 +0100)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 11 Mar 2020 14:20:24 +0000 (11:20 -0300)
commit67439d555f7d46349deef56886129da96bd15744
tree32f98af9a531c443812c1ddebd3624c62315eb6a
parentec2eab9deb8009fd8c69d61d04c66b77d438f17d
perf scripting perl: Add common_callchain to fix argument order

Since common_callchain has been added to the argument array, we need to
reflect it in perl-based scripts, because otherwise the following args
would be shifted and thus incorrect. E.g. rw-by-pid and calculation of
read and written bytes:

Before:

  read counts by pid:
     pid                  comm     # reads  bytes_requested  bytes_read
  ------  --------------------  -----------  ----------  ----------
   19301  dd                             4  424510450039736           0

After:

  read counts by pid:
     pid                  comm     # reads  bytes_requested  bytes_read
  ------  --------------------  -----------  ----------  ----------
   19301  dd                             4        9536             4341

Committer testing:

To see before after first do:

  # perf script record rw-by-pid
  ^C

Now you'll have a perf.data file to report on, then do before and after
using:

  # perf script report rw-by-pid

Anbd notice the bytes_request/bytes_read, as above.

Signed-off-by: Michael Petlan <mpetlan@redhat.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Benjamin Salon <bsalon@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
LPU-Reference: 20200311132836.12693-1-mpetlan@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/scripts/perl/check-perf-trace.pl
tools/perf/scripts/perl/failed-syscalls.pl
tools/perf/scripts/perl/rw-by-file.pl
tools/perf/scripts/perl/rw-by-pid.pl
tools/perf/scripts/perl/rwtop.pl
tools/perf/scripts/perl/wakeup-latency.pl