vfs: remove redundant checks from generic_remap_checks()
authorAmir Goldstein <amir73il@gmail.com>
Wed, 5 Jun 2019 15:04:48 +0000 (08:04 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Sun, 9 Jun 2019 17:06:19 +0000 (10:06 -0700)
commit646955cd5425dd8fed8205cbb1b4373c222d028e
treeb05036cc5e7433a38305db3f6910bc7905bc067a
parenta31713517dac0862a3f0ec9006df9160ce022b0c
vfs: remove redundant checks from generic_remap_checks()

The access limit checks on input file range in generic_remap_checks()
are redundant because the input file size is guaranteed to be within
limits and pos+len are already checked to be within input file size.

Beyond the fact that the check cannot fail, if it would have failed,
it could return -EFBIG for input file range error. There is no precedent
for that. -EFBIG is returned in syscalls that would change file length.

With that call removed, we can fold generic_access_check_limits() into
generic_write_check_limits().

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
mm/filemap.c