ALSA: pcm: Clear the full allocated memory at hw_params
authorTakashi Iwai <tiwai@suse.de>
Fri, 18 Dec 2020 14:56:25 +0000 (15:56 +0100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 18 Dec 2020 16:09:28 +0000 (17:09 +0100)
commit618de0f4ef11acd8cf26902e65493d46cc20cc89
treea56c4b1232cfe02a3dcdc09373c5c85061e176c4
parent5c1733e33c888a3cb7f576564d8ad543d5ad4a9e
ALSA: pcm: Clear the full allocated memory at hw_params

The PCM hw_params core function tries to clear up the PCM buffer
before actually using for avoiding the information leak from the
previous usages or the usage before a new allocation.  It performs the
memset() with runtime->dma_bytes, but this might still leave some
remaining bytes untouched; namely, the PCM buffer size is aligned in
page size for mmap, hence runtime->dma_bytes doesn't necessarily cover
all PCM buffer pages, and the remaining bytes are exposed via mmap.

This patch changes the memory clearance to cover the all buffer pages
if the stream is supposed to be mmap-ready (that guarantees that the
buffer size is aligned in page size).

Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20201218145625.2045-3-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm_native.c